Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 2-February-2024 #792

Merged
merged 61 commits into from
Feb 16, 2024
Merged

version 2-February-2024 #792

merged 61 commits into from
Feb 16, 2024

Conversation

neurolabusc
Copy link
Collaborator

Stable release v1.0.20240202

  • Consolidates incremental improvements (see closed issues for details).
  • Introduces BidsGuess field to json file that aids identifying modality.

ningfei and others added 30 commits April 27, 2023 21:26
Replace JNIfTI by JNIFTI in makefile macros
in the BIDS (.json) sidecar in cose of image interpolation.

TotalReadoutTime and EffectiveEchoSpacing were correct when there was
no interpolation (i.e. AcquisitionMatrixPE = ReconMatrixPE).
However, when interpolation was used, this values were incorrect.
When interpolation was used, the estimated fieldmap given by TOPUP
was ReconMatrixPE/AcquisitionMatrixPE times a measured fieldmap.
Also, the same interpolated images corrected with a B0Map based method
via FSL's epi_reg were clearly under-corrected.
It turned out that the problem was comming from TotalReadoutTime and
EffectiveEchoSpacing which were not taking ReconMatrixPE correctly
into account.
This is a Fix for that.

GE/README.md was modified to clarified how TotalReadoutTime and
EffectiveEchoSpacing are now computed.
Some intermediate variable were also introduced and this described.
This should help he final user to better understand.

console/nii_dicom_batch.cpp was modified to implement the changes on
TotalReadoutTime and EffectiveEchoSpacing.
The intermediate variables described in README were also added into
the json BIDS sidecar (i.e. EchoSpacingMicroSecondsGE,
NotPhysicalNumberOfAcquiredPELinesGE, NotPhysicalTotalReadOutTimeGE).
As the TotalReadoutTime definition is not intuitive this should
help the user to understand what is going on.

On branch dev-fix-TotalReadoutTimeGE-with-interpolation
Changes to be committed:
	modified:   GE/README.md
	modified:   console/nii_dicom_batch.cpp
…interpolation

Dev fix TotalReadoutTime for GE with interpolation
  1. save dicom file list in MRIFSSTRUCT, return vector of MRIFSSTRUCT for multi-echo scans if isForceStackSameSeries = 0 (-m n)
  2. change output file format to "%4s.%d" from "%4s.%p" to be consistent with Freesurfer dcmunpack
  3. remove space, [, ] from scan description
  4. implement isDumpNotConvert option to retrieve dicom info only
  5. dcm2niix_fswrapper::dicomDump() - output information of series to be converted, and seriesNum-dicomflst.txt in the same directory as series-info.dat;
     dcm2niix_fswrapper::seriesInfoDump() - print information for given dicom series
  6. don't use std::max() from <algorithm> (fix Freesurfer ubuntu18 compiler error)
It is now clarified that the `EchoSpacing` variable is the GE private
DICOM field "(0043,102C) Effective Echo Spacing".

On branch fix-documentation-GE-TotalReadoutTime
Changes to be committed:
	modified:   GE/README.md
…tTime

Documentation fix for GE TotalReadoutTime.
Fix typos in GE/README.md and code mofification to add the intermediate variables
for TotalReadoutTime on GE system in debug mode only (via compilation flag MY_DEBUG).

Added a note for that in GE/README.md:

For debugging purposes, the intermediate variables `NotPhysicalTotalReadOutTimeGE`, `NotPhysicalNumberOfAcquiredPELinesGE` and `EchoSpacing` (renamed `EchoSpacingMicroSecondsGE`) are written to the BIDS-sidecar JSON file when dcm2niix is compiled with the flag `MY_DEBUG`.

On branch dev-fix-GETotalReadoutTime-doc-and-code
Changes to be committed:
	modified:   GE/README.md
	modified:   console/nii_dicom_batch.cpp
…nd-code

Fix code and doc for GE TotalReadoutTime
dcm2niix_fswrapper and libdcm2niixfs.a
neurolabusc and others added 29 commits September 12, 2023 12:17
issue 769: Mildly relax the check for bvec components > 1.
Fix PhaseEncodingDirectionDisplayed for GE #779
@neurolabusc neurolabusc merged commit e2ead4b into master Feb 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants